First Implementation of Johnson Graph Algorithm #12281
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s): |
There was a problem hiding this comment.
Please provide return type hint for the function: dijkstra. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph[u] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, u, v, w) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
Please provide type hint for the parameter: u
Please provide descriptive name for the parameter: u
Please provide type hint for the parameter: v
Please provide descriptive name for the parameter: v
Please provide type hint for the parameter: w
Please provide descriptive name for the parameter: w
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| return distances | ||
|
|
||
| #carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| #or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph: Dict[str, int] = {} | ||
|
|
||
| # add vertices for a graph | ||
| def add_vertices(self, u) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_vertices
Please provide type hint for the parameter: u
Please provide descriptive name for the parameter: u
graphs/johnson_graph.py
Outdated
| self.graph[u] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, u, v, w) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
Please provide type hint for the parameter: u
Please provide descriptive name for the parameter: u
Please provide type hint for the parameter: v
Please provide descriptive name for the parameter: v
Please provide type hint for the parameter: w
Please provide descriptive name for the parameter: w
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| return distances | ||
|
|
||
| # carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| # or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph: dict[str, int] = {} | ||
|
|
||
| # add vertices for a graph | ||
| def add_vertices(self, u) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_vertices
Please provide type hint for the parameter: u
Please provide descriptive name for the parameter: u
graphs/johnson_graph.py
Outdated
| self.graph[u] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, u, v, w) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
Please provide type hint for the parameter: u
Please provide descriptive name for the parameter: u
Please provide type hint for the parameter: v
Please provide descriptive name for the parameter: v
Please provide type hint for the parameter: w
Please provide descriptive name for the parameter: w
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| return distances | ||
|
|
||
| # carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, s) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
Please provide type hint for the parameter: s
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| # or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph: dict[str, list[tuple[str, int]]] = {} | ||
|
|
||
| # add vertices for a graph | ||
| def add_vertices(self, u: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_vertices
Please provide descriptive name for the parameter: u
graphs/johnson_graph.py
Outdated
| self.graph[u] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, u: str, v: str, w: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
Please provide descriptive name for the parameter: w
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| return distances | ||
|
|
||
| # carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, s: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
Please provide descriptive name for the parameter: s
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| # or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> list[dict]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/johnson_graph.py
Outdated
| self.graph: dict[str, list[tuple[str, int]]] = {} | ||
|
|
||
| # add vertices for a graph | ||
| def add_vertices(self, u: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_vertices
Please provide descriptive name for the parameter: u
graphs/johnson_graph.py
Outdated
| self.graph[u] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, u: str, v: str, w: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
Please provide descriptive name for the parameter: u
Please provide descriptive name for the parameter: v
Please provide descriptive name for the parameter: w
graphs/johnson_graph.py
Outdated
| self.graph[u].append((v, w)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, s: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
Please provide descriptive name for the parameter: s
graphs/johnson_graph.py
Outdated
| return distances | ||
|
|
||
| # carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, s: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
Please provide descriptive name for the parameter: s
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| # or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> list[dict]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
algorithms-keeper
bot
removed
the
tests are failing
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.graph: dict[str, list[tuple[str, int]]] = {} | ||
|
|
||
| # add vertices for a graph | ||
| def add_vertices(self, vertex: str) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_vertices
| self.graph[vertex] = [] | ||
|
|
||
| # assign weights for each edges formed of the directed graph | ||
| def add_edge(self, vertex_a: str, vertex_b: str, weight: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function add_edge
| self.graph[vertex_a].append((vertex_b, weight)) | ||
|
|
||
| # perform a dijkstra algorithm on a directed graph | ||
| def dijkstra(self, start: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function dijkstra
| return distances | ||
|
|
||
| # carry out the bellman ford algorithm for a node and estimate its distance vector | ||
| def bellman_ford(self, start: str) -> dict: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function bellman_ford
| # perform the johnson algorithm to handle the negative weights that | ||
| # could not be handled by either the dijkstra | ||
| # or the bellman ford algorithm efficiently | ||
| def johnson_algo(self) -> list[dict]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file graphs/johnson_graph.py, please provide doctest for the function johnson_algo
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
Describe your change:
Checklist: